[codex] Normalize server core Effect service modules

[juliusmarminge]

Summary

• normalize config, keybindings, lifecycle events, runtime startup, and server settings around inline Context.Service interfaces plus colocated make / layer exports
• use Layer.effect only for genuinely effectful service construction; the externally constructed ServerConfig now has a pure value make(config) and Layer.succeed factory
• namespace-import every relative service module touched by the refactor and access tags, layers, helpers, errors, and types through that namespace
• replace standalone service shape types with Service["Service"] references across affected consumers
• model ServerRuntimeStartupError as a structured Schema.TaggedErrorClass whose message is derived from its startup stage
• preserve parameterized test-layer semantics while moving live dependency wiring to the composition root

Orchestration modules and excluded MCP service files are intentionally unchanged because orchestration is being reworked in #2829.

Impact

This standardizes the server core services on the Effect module layout already used by newer infrastructure. Runtime behavior is unchanged except for the intentionally structured startup error shape and derived message. Each layer now reflects whether construction is pure or effectful instead of wrapping pure service values in synthetic effects.

No test cases were added solely for this structural refactor; existing tests were updated only where their imports or structured error construction changed.

Validation

• vp check (pass; 20 unrelated existing warnings)
• vp run typecheck
• affected server test files: 13 passed, 224 tests passed
• service import audit: zero named relative imports from Context.Service modules, zero layer as aliases, zero standalone *Shape references

---

Note

Low Risk
Mechanical refactor with tests updated; the only intentional behavior change is structured ServerRuntimeStartupError shape/message, and ServerSettings secret-store wiring moved to an explicit parent layer.

Overview
Refactors server core Effect services (ServerConfig, Keybindings, ServerLifecycleEvents, ServerRuntimeStartup, ServerSettings) to match the newer module pattern: service APIs live on Context.Service classes (no separate *Shape types), with colocated make / layer exports replacing *Live and ad-hoc Layer.succeed wiring.

ServerConfig gains pure make(config) and layer(config) factories; tests use layerTest as a module export (static ServerConfig.layerTest kept as deprecated shim). Call sites switch to namespace imports and Service["Service"] for config typing.

ServerRuntimeStartupError becomes a Schema.TaggedErrorClass with a stage field (e.g. "command-readiness") and a derived message; tests assert the new wording.

ServerSettings.layer no longer embeds ServerSecretStore—server.ts provides it at the composition root alongside other runtime layers.

Touched files are mostly import/layer/test updates across CLI, auth tests, provider tests, and HTTP server wiring; orchestration modules are out of scope per the PR description.

^{Reviewed by Cursor Bugbot for commit f5e74d0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Normalize Effect service modules in server core to use namespace imports and inlined service shapes

• Replaces named imports with namespace-style * as Module imports across server core modules, tests, and CLI code, so service tags and types are accessed as Module.ServiceName (e.g. ServerConfig.ServerConfig, Keybindings.Keybindings).
• Removes separate *Shape interfaces (e.g. ServerConfigShape, KeybindingsShape, ServerLifecycleEventsShape) and inlines service contracts directly into the Context.Service generic.
• Renames live layer exports to a consistent layer convention (e.g. KeybindingsLive → Keybindings.layer, ServerSettingsLive → ServerSettings.layer, ServerRuntimeStartupLive → ServerRuntimeStartup.layer).
• Replaces Layer.succeed(ServerConfig, config) call sites with ServerConfig.layer(config), meaning layer acquisition/release logic now runs wherever config is provided.
• Rewrites ServerRuntimeStartupError as a Schema.TaggedErrorClass with a structured stage field; the error message is now always 'Server runtime startup failed before command readiness.' instead of a caller-supplied string.
• The production ServerSettings.layer no longer internally provides ServerSecretStore.layer; callers must now compose ServerSecretStore.layer explicitly.

^{Macroscope summarized f5e74d0.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ffa77315-adb2-4e09-a0b2-e52582f8da4d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/effect-service-server-core

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Expo continuous deployment is ready!

• Project → t3-code
• Platforms → android, ios
• Scheme → t3code-preview

	🤖 Android	🍎 iOS
Fingerprint	fe5a51f2e189da69dfc4c2cd458e6cfb5fdff2ea	ae3bd597809dfd7771d0898f735d172973d4c1c8
Build Details	Build Permalink Details Distribution: INTERNAL Build profile: preview:dev Runtime version: fe5a51f2e189da69dfc4c2cd458e6cfb5fdff2ea App version: 0.1.0 Git commit: 5b4a2a632cd3cfbf0cc350a4f63300ef8a71bdf4	Build Permalink Details Distribution: INTERNAL Build profile: preview:dev Runtime version: ae3bd597809dfd7771d0898f735d172973d4c1c8 App version: 0.1.0 Git commit: 5a7182ae66b2070fc19716b30aef093443628423
Update Details	Update Permalink Details Branch: pr-3187 Runtime version: fe5a51f2e189da69dfc4c2cd458e6cfb5fdff2ea Git commit: 5b4a2a632cd3cfbf0cc350a4f63300ef8a71bdf4	Update Permalink Details Branch: pr-3187 Runtime version: ae3bd597809dfd7771d0898f735d172973d4c1c8 Git commit: 5b4a2a632cd3cfbf0cc350a4f63300ef8a71bdf4
Update QR

[macroscopeapp]

Approvability

Verdict: Approved

Mechanical refactoring that normalizes Effect service module import patterns and type definitions across the server codebase. No runtime behavior changes - only code organization and import styles are updated.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate f5e74d0