fix(web): remove duplicate provider update progress

[naveed949]

Problem

Starting a one-click provider update kept the initial toast visible as a persistent Updating provider status while the sidebar pill showed the same running update. This duplicated progress in two UI locations.

Fixes #7425.

What changed

• Close the update-available toast when a one-click update starts, leaving the sidebar pill as the canonical running-status UI.
• Preserve terminal success, failure, and unchanged outcome toasts, including transport-level failures.
• Add focused coverage for hiding only the primary running-phase toast while preserving the initial prompt and terminal outcomes.

UI changes

Before

The running update appears in both a persistent toast and the sidebar pill.

After

Only the sidebar pill shows the running update.

Verification

• vp test run apps/web/src/components/ProviderUpdateLaunchNotification.logic.test.ts — 47 passed
• vp lint apps/web/src/components/ProviderUpdatePrimaryNotification.tsx apps/web/src/components/ProviderUpdateLaunchNotification.logic.ts apps/web/src/components/ProviderUpdateLaunchNotification.logic.test.ts
• vp fmt --check apps/web/src/components/ProviderUpdatePrimaryNotification.tsx apps/web/src/components/ProviderUpdateLaunchNotification.logic.ts apps/web/src/components/ProviderUpdateLaunchNotification.logic.test.ts
• vp run --filter @t3tools/web typecheck
• Manually verified in T3 Code Desktop with one-click Claude provider update

Created by gpt-5.6-sol using the Codex harness in T3 Code.

Note

Remove duplicate provider update running toast in ProviderUpdatePrimaryNotification

• The primary provider update flow no longer shows a running/loading toast; only the initial prompt and terminal outcome (success/unchanged/failed) toasts appear.
• Adds shouldShowPrimaryProviderUpdateToast to gate toast display by phase, returning false when view.phase is 'running'.
• Replaces in-place toast updates with addProviderUpdateToast, which always creates a new toast and ensures the Settings action closes the specific clicked toast.
• Removes updateProviderUpdateToast, isTerminalProviderUpdateToastView, and active toastId tracking for the update flow.
• Risk: ProviderUpdatePrimaryNotification no longer displays progress while updates run; callers expecting a visible running toast will not see one.

^{Macroscope summarized ab1816a.}

---

Note

Low Risk
UI-only toast lifecycle change for provider updates; no auth, data, or backend behavior is affected.

Overview
Stops duplicating one-click provider update progress: the prompt toast is closed when an update starts, and running-phase toasts are no longer shown so the sidebar pill is the only in-flight status.

Terminal success, failure, and unchanged outcomes still appear as new toasts (not in-place updates). shouldShowPrimaryProviderUpdateToast gates that, and cleanup only closes prompt toasts.

^{Reviewed by Cursor Bugbot for commit ab1816a. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7161283e-3ad4-4914-95d5-72dedfd66da5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

One finding on the removed running-state toast — see the inline comment.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Approved at ab1816a

Macroscope's review found this PR approvable — This is a straightforward UI bug fix that removes duplicate toast notifications during provider updates. The changes are self-contained to toast notification logic with tests added, clear intent, and no impact on security or data handling.

^{You can add or adjust custom eligibility rules. Learn more.}