fix(server): abort OpenCode child sessions on interrupt - #7770
Draft
NitayRabi wants to merge 2 commits into
Draft
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7769.
Why
OpenCode sub-agents use child sessions. Relying only on
session.abort(parent)leaves T3 dependent on the installed OpenCode version propagating cancellation to all children. When that propagation fails, the child provider stream remains alive and can occupy a single-slot local inference server indefinitely.Validation
vp test apps/server/src/provider/Layers/OpenCodeAdapter.test.ts(33 passed)vp run --filter t3 typecheckvp fmt --check apps/server/src/provider/Layers/OpenCodeAdapter.ts apps/server/src/provider/Layers/OpenCodeAdapter.test.tsgit diff --checkNote
Abort OpenCode child sessions before parent in
interruptTurninterruptTurnnow queriescontext.client.session.childrenand aborts each child session concurrently before aborting the parent, continuing even if individual child aborts fail.abortOpenCodeSessionTreehelper to OpenCodeAdapter.ts to encapsulate this ordering and error handling.abortCallsbefore the parent session URL.session.childrenfailures default to an empty list, so a failing children query silently skips child aborts rather than surfacing the error.📊 Macroscope summarized 05630bb. 1 file reviewed, 1 issue evaluated, 0 issues filtered, 1 comment posted
🗂️ Filtered Issues