Skip to content

fix(web): model picker no longer shows a double border - #7772

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
RakshithBhat03:fix/model-picker-double-border
Aug 21, 2026
Merged

fix(web): model picker no longer shows a double border#7772
maria-rcks merged 1 commit into
pingdotgg:mainfrom
RakshithBhat03:fix/model-picker-double-border

Conversation

@RakshithBhat03

@RakshithBhat03 RakshithBhat03 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

The model picker wrapped the same surface in two glass containers, leaving a doubled rounded border in both light and dark themes.

The popover now owns the glass background, border, clipping, and shadow. The picker content only controls layout, so the menu has one clean edge without changing its dimensions or selection behavior.

Verification

  • vp lint apps/web/src/components/chat/ModelPickerContent.tsx apps/web/src/components/chat/ProviderModelPicker.tsx
  • vp fmt --check apps/web/src/components/chat/ModelPickerContent.tsx apps/web/src/components/chat/ProviderModelPicker.tsx
  • Verified the model picker locally in light and dark modes with before/after browser captures.
  • vp run --filter @t3tools/web typecheck is currently blocked by pre-existing conditionalUI errors in apps/web/src/components/clerk/electronPasskeys.test.ts at lines 42 and 55.

Screenshots

Before After
Light mode
Model picker before the fix in light mode
Light mode
Model picker after the fix in light mode
Dark mode
Model picker before the fix in dark mode
Dark mode
Model picker after the fix in dark mode

Built by GPT-5.6 Sol in T3 Code through the Codex harness.


Note

Low Risk
Pure CSS/layout tweak on the model picker popover. No logic, auth, or data-handling changes.

Overview
Stops the model picker from stacking two glass surfaces, which produced a doubled rounded border in light and dark themes.

ModelPickerContent now only handles layout. Glass background, border, clip, and shadow live on the popover viewport so the menu has a single clean edge without changing size or selection behavior.

Reviewed by Cursor Bugbot for commit ab57134. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-authored-by: GPT-5.6 <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b284b3c7-5ed7-4d0b-88a7-b770901f42b8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 21, 2026
@RakshithBhat03
RakshithBhat03 marked this pull request as ready for review August 21, 2026 09:17
@macroscopeapp

macroscopeapp Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at ab57134

Macroscope's review found this PR approvable — This PR makes purely CSS class changes to fix a visual double-border bug in the model picker component. The modifications only affect styling with no runtime behavior impact, making this a straightforward low-risk UI fix.

You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcks merged commit 292c6dd into pingdotgg:main Aug 21, 2026
28 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 21, 2026
## What's Changed
* feat(web): double-click chat header title to rename thread by @UtkarshUsername in pingdotgg/t3code#7817
* fix(web): model picker no longer shows a double border by @RakshithBhat03 in pingdotgg/t3code#7772
* fix(web): give sidebar un-settle button a tooltip by @UtkarshUsername in pingdotgg/t3code#7796
* fix(web): render oversized terminal graphemes without crashing by @Lucenx9 in pingdotgg/t3code#7809


**Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260821.1153...v0.0.34-nightly.20260821.1154

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260821.1154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants