fix(web): model picker no longer shows a double border - #7772
Conversation
Co-authored-by: GPT-5.6 <noreply@openai.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This PR makes purely CSS class changes to fix a visual double-border bug in the model picker component. The modifications only affect styling with no runtime behavior impact, making this a straightforward low-risk UI fix. You can add or adjust custom eligibility rules. Learn more. |
## What's Changed * feat(web): double-click chat header title to rename thread by @UtkarshUsername in pingdotgg/t3code#7817 * fix(web): model picker no longer shows a double border by @RakshithBhat03 in pingdotgg/t3code#7772 * fix(web): give sidebar un-settle button a tooltip by @UtkarshUsername in pingdotgg/t3code#7796 * fix(web): render oversized terminal graphemes without crashing by @Lucenx9 in pingdotgg/t3code#7809 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260821.1153...v0.0.34-nightly.20260821.1154 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260821.1154
The model picker wrapped the same surface in two glass containers, leaving a doubled rounded border in both light and dark themes.
The popover now owns the glass background, border, clipping, and shadow. The picker content only controls layout, so the menu has one clean edge without changing its dimensions or selection behavior.
Verification
vp lint apps/web/src/components/chat/ModelPickerContent.tsx apps/web/src/components/chat/ProviderModelPicker.tsxvp fmt --check apps/web/src/components/chat/ModelPickerContent.tsx apps/web/src/components/chat/ProviderModelPicker.tsxvp run --filter @t3tools/web typecheckis currently blocked by pre-existingconditionalUIerrors inapps/web/src/components/clerk/electronPasskeys.test.tsat lines 42 and 55.Screenshots
Built by GPT-5.6 Sol in T3 Code through the Codex harness.
Note
Low Risk
Pure CSS/layout tweak on the model picker popover. No logic, auth, or data-handling changes.
Overview
Stops the model picker from stacking two glass surfaces, which produced a doubled rounded border in light and dark themes.
ModelPickerContentnow only handles layout. Glass background, border, clip, and shadow live on the popover viewport so the menu has a single clean edge without changing size or selection behavior.Reviewed by Cursor Bugbot for commit ab57134. Bugbot is set up for automated code reviews on this repo. Configure here.