Skip to content

fix(web): dialogs and palettes no longer render under the composer slash menu #8152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaneeilia-bridgit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(web): dialogs and palettes no longer render under the composer slash menu #8152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/src/components/ui/alert-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function AlertDialogViewport({ className, ...props }: AlertDialogPrimitive.Viewp
return (
<AlertDialogPrimitive.Viewport
className={cn(
"fixed inset-0 z-50 grid grid-rows-[1fr_auto_1fr] justify-items-center p-4",
"fixed inset-0 z-[80] grid grid-rows-[1fr_auto_1fr] justify-items-center p-4",
className,
)}
data-slot="alert-dialog-viewport"
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/ui/command.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function CommandDialogViewport({ className, ...props }: CommandDialogPrimitive.V
return (
<CommandDialogPrimitive.Viewport
className={cn(
"pointer-events-none fixed inset-0 z-50 flex flex-col items-center px-4 py-[max(--spacing(4),4vh)] sm:py-[10vh]",
"pointer-events-none fixed inset-0 z-[80] flex flex-col items-center px-4 py-[max(--spacing(4),4vh)] sm:py-[10vh]",
className,
)}
data-slot="command-dialog-viewport"
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/ui/dialog-styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const DIALOG_BACKDROP_CLASS =
"dialog-backdrop fixed inset-0 z-50 transition-all duration-200 data-ending-style:opacity-0 data-starting-style:opacity-0";
"dialog-backdrop fixed inset-0 z-[80] transition-all duration-200 data-ending-style:opacity-0 data-starting-style:opacity-0";

const DIALOG_POPUP_CLASS =
"dialog-glass -translate-y-[calc(1.25rem*var(--nested-dialogs))] relative flex min-h-0 w-full min-w-0 scale-[calc(1-0.1*var(--nested-dialogs))] flex-col rounded-2xl border opacity-[calc(1-0.1*var(--nested-dialogs))] outline-none transition-[scale,opacity,translate] duration-200 ease-in-out will-change-transform data-nested:data-ending-style:translate-y-8 data-nested:data-starting-style:translate-y-8 data-nested-dialog-open:origin-top data-ending-style:scale-98 data-starting-style:scale-98 data-ending-style:opacity-0 data-starting-style:opacity-0";
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/ui/dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ function DialogViewport({ className, ...props }: DialogPrimitive.Viewport.Props)
return (
<DialogPrimitive.Viewport
className={cn(
"fixed inset-0 z-50 grid grid-rows-[1fr_auto_1fr] justify-items-center p-4",
"fixed inset-0 z-[80] grid grid-rows-[1fr_auto_1fr] justify-items-center p-4",
className,
)}
data-slot="dialog-viewport"
Expand Down
4 changes: 2 additions & 2 deletions apps/web/src/components/ui/sheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function SheetBackdrop({ className, ...props }: SheetPrimitive.Backdrop.Props) {
return (
<SheetPrimitive.Backdrop
className={cn(
"fixed inset-0 z-50 bg-background/60 backdrop-blur-xs transition-all duration-200 data-ending-style:opacity-0 data-starting-style:opacity-0",
"fixed inset-0 z-[80] bg-background/60 backdrop-blur-xs transition-all duration-200 data-ending-style:opacity-0 data-starting-style:opacity-0",
className,
)}
data-slot="sheet-backdrop"
Expand All @@ -43,7 +43,7 @@ function SheetViewport({
return (
<SheetPrimitive.Viewport
className={cn(
"fixed inset-0 z-50 grid",
"fixed inset-0 z-[80] grid",
side === "bottom" && "grid grid-rows-[1fr_auto] pt-12",
side === "top" && "grid grid-rows-[auto_1fr] pb-12",
side === "left" && "flex justify-start",
Expand Down
Loading