Fix resumed thread working indicators#886
Open
Aditya190803 wants to merge 1 commit intopingdotgg:mainfrom
Open
Fix resumed thread working indicators#886Aditya190803 wants to merge 1 commit intopingdotgg:mainfrom
Aditya190803 wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Resumed interrupted threads now continue to show active processing state in both the chat view and the sidebar even when the legacy
session.statushas already fallen back toreadybutorchestrationStatusis still active. Fixes #881.session-logic:
derivePhase()now treats orchestration status as canonical for connecting and running states via sharedisSessionConnecting()andisSessionRunning()helpers.Sidebar.logic: thread status pills now use
derivePhase(thread.session)instead of reading the legacy session status directly, so resumed threads still showWorkingorConnectingwhen orchestration is active.session-logic.test / Sidebar.logic.test: added regression coverage for resumed-running, orchestration-starting, and mismatched legacy-vs-orchestration precedence cases.
ChatView.browser: added a rendered browser regression test that reproduces the stale resumed-thread state and verifies the chat working indicator and sidebar badge both stay visible.
Why
Interrupted thread resume could leave the UI looking idle while the orchestration layer was still actively processing. In that state the user got no reliable feedback about whether the resumed thread was working, retrying, or stuck, which is exactly the issue reported in #881.
UI Changes
before
resumed interrupted threads could look idle after reconnecting because neither the chat timeline nor the sidebar reliably showed an active processing indicator while orchestration was still running.
after
resumed interrupted threads keep showing the working indicator in the chat and the
Workingbadge in the sidebar while orchestration remains active.Checklist
Note
Fix working indicators for resumed threads by using
orchestrationStatusinderivePhasederivePhasein session-logic.ts now checksorchestrationStatusalongside legacysession.status, treating'starting'as'connecting'and'running'as'running'even when legacy status is'ready'.resolveThreadStatusPillin Sidebar.logic.ts is updated to usederivePhase, so the sidebar pill label and pulse dot correctly show 'Working' or 'Connecting' for resumed threads.derivePhaseandresolveThreadStatusPillfor mixed legacy/orchestration states, and a new browser test asserts both the chat and sidebar indicators are visible when a resumed thread is active.Macroscope summarized b44b33a.