fix(web): add default thread env mode setting#892
Open
binbandit wants to merge 2 commits intopingdotgg:mainfrom
Open
fix(web): add default thread env mode setting#892binbandit wants to merge 2 commits intopingdotgg:mainfrom
binbandit wants to merge 2 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New worktreeon each new threadWhy
New draft threads always defaulted to
local, even if a user consistently works inNew worktreemode. The existing toggle only changed the current draft thread, so users had to repeat the same interaction on every new thread.The right scope here is app-level persistence, not more draft-local state. That keeps existing thread behavior unchanged, preserves explicit overrides, and only affects brand-new draft thread creation.
Changes
defaultThreadEnvModeLocalandNew worktreeenvModeis already suppliedworktreemodeUI changes
Validation
bun run test src/appSettings.test.ts src/composerDraftStore.test.tsinapps/webbun fmtbun lintbun typecheckNote
Add configurable default thread environment mode setting to the sidebar and settings UI
defaultThreadEnvModefield ('local'|'worktree', default'local') toAppSettingsSchema._chat.settings.tsxwith a toggle and restore-default button for this setting.Sidebar.tsxto usedefaultThreadEnvModewhen creating new threads instead of a hardcoded'local'; the local-new-thread keyboard shortcut continues to force'local'.resolveSidebarNewThreadEnvModeto resolve the env mode using an explicit request or fall back to the app default.'local'.Macroscope summarized 000ce3a.