Skip to content

fix: show unread error state in thread prefixes#893

Open
binbandit wants to merge 1 commit intopingdotgg:mainfrom
binbandit:t3code/add-thread-error-prefix-state
Open

fix: show unread error state in thread prefixes#893
binbandit wants to merge 1 commit intopingdotgg:mainfrom
binbandit:t3code/add-thread-error-prefix-state

Conversation

@binbandit
Copy link
Contributor

@binbandit binbandit commented Mar 11, 2026

Summary

  • derive an unseen error signal from error activities, failed turns, and session errors
  • show an Error thread prefix before other sidebar status pills when that signal is present
  • clear the unread error state when the user opens the affected thread

Validation

  • bun run test src/components/Sidebar.logic.test.ts
  • bun fmt
  • bun lint
  • bun typecheck

Note

Add unread error state to thread prefix pills in the sidebar

  • Adds hasUnseenError in thread-status.ts that detects unseen errors from activities with tone: 'error', turn state, or session lastError, using a shared happenedAfterLastVisit helper.
  • Updates resolveThreadStatusPill in Sidebar.logic.ts to return a red 'Error' pill when hasUnseenError is true, taking precedence over other statuses.
  • Marks a thread as visited in ChatView.tsx when it becomes active and has an unseen error, clearing the error indicator.

Macroscope summarized 87fc95c.

@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cdb4e44f-9b29-4d44-8c43-84014a9693c9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Mar 11, 2026
@binbandit binbandit changed the title Add unread error state to thread prefixes fix: show unread error state in thread prefixes Mar 11, 2026
@jamesx0416
Copy link
Contributor

@binbandit Should probably add a screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants