fix(web): add pointer cursor to running stop-generation button#900
Open
binbandit wants to merge 1 commit intopingdotgg:mainfrom
Open
fix(web): add pointer cursor to running stop-generation button#900binbandit wants to merge 1 commit intopingdotgg:mainfrom
binbandit wants to merge 1 commit intopingdotgg:mainfrom
Conversation
- Add `cursor-pointer` to the running stop button in `ChatView` - Extend browser test snapshot helpers to set session status - Add regression test verifying stop button cursor is `pointer` while running
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cursor-pointerto the running stop button in the thread composerValidation
bun fmtbun lintbun typecheckbun run test:browser -- -t "shows a pointer cursor for the running stop button"Note
Add pointer cursor to the 'Stop generation' button when session is running
Adds
cursor-pointerto the 'Stop generation' button in ChatView.tsx so it looks interactive during a running session. A new browser test verifies the computed style, using an extendedcreateSnapshotForTargetUserhelper that now accepts an optionalsessionStatusparameter.Macroscope summarized 4b0e9eb.