Skip to content

fix(web): add pointer cursor to running stop-generation button#900

Open
binbandit wants to merge 1 commit intopingdotgg:mainfrom
binbandit:t3code/fix-stop-button-cursor
Open

fix(web): add pointer cursor to running stop-generation button#900
binbandit wants to merge 1 commit intopingdotgg:mainfrom
binbandit:t3code/fix-stop-button-cursor

Conversation

@binbandit
Copy link
Contributor

@binbandit binbandit commented Mar 11, 2026

Summary

  • add cursor-pointer to the running stop button in the thread composer
  • add a browser regression test that asserts the rendered stop button exposes a pointer cursor while the thread is running

Validation

  • bun fmt
  • bun lint
  • bun typecheck
  • bun run test:browser -- -t "shows a pointer cursor for the running stop button"

Note

Add pointer cursor to the 'Stop generation' button when session is running

Adds cursor-pointer to the 'Stop generation' button in ChatView.tsx so it looks interactive during a running session. A new browser test verifies the computed style, using an extended createSnapshotForTargetUser helper that now accepts an optional sessionStatus parameter.

Macroscope summarized 4b0e9eb.

- Add `cursor-pointer` to the running stop button in `ChatView`
- Extend browser test snapshot helpers to set session status
- Add regression test verifying stop button cursor is `pointer` while running
@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 496a6076-efcc-4f9f-bdfd-c4e05c0705c6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Mar 11, 2026
@binbandit binbandit changed the title Add pointer cursor to running stop-generation button fix(web): add pointer cursor to running stop-generation button Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant