fix(server): respect fork remotes when creating PRs#904
Open
binbandit wants to merge 1 commit intopingdotgg:mainfrom
Open
fix(server): respect fork remotes when creating PRs#904binbandit wants to merge 1 commit intopingdotgg:mainfrom
binbandit wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--repo <base>and--head <owner>:<branch>, and add regression coverage fororigin=fork, upstream=baselayoutsProblem
The create-pr flow inferred too much from the local remote layout. In a common fork setup where
originpoints at a fork andupstreampoints at the main repository, the server could look up and create PRs against the wrong repository. It also depended on owner-qualifiedgh pr list --headbehavior that the real GitHub CLI does not support.Testing
Note
Fix PR creation and detection to respect fork remotes in
GitManagergetRepositoryMetadatatoGitHubCliShapeand its implementation, fetching fork status, default branch, and parent repository fromgh repo view.resolveBranchHeadContextin GitManager.ts to detect fork remotes and resolve the correct base repository (using parent repo when the head is a fork).createPullRequestnow passes--repo <base>togh pr createwhen a base repository is resolved, targeting the upstream repo instead of the fork.findOpenPr,findLatestPr) switches from probing multiple head selector variants to a singlegh pr list --repo <base> --head <branch>call filtered by repository/owner match.Macroscope summarized 5e30124.