Cache sidebar content for instant render on subsequent launches#946
Open
ratley wants to merge 1 commit intopingdotgg:mainfrom
Open
Cache sidebar content for instant render on subsequent launches#946ratley wants to merge 1 commit intopingdotgg:mainfrom
ratley wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Caches the sidebar project & thread titles.
Why
The sidebar currently doesn't render anything until the WebSocket is connected, resulting in "No projects yet" being shown for a couple of seconds when the app is opened. This is a UX improvement.
UI Changes
Before
t3-sidebar-before.mov
After
t3-sidebar-after.mov
Checklist
Note
Cache sidebar projects and threads in localStorage for instant render on subsequent launches
readPersistedStatein store.ts now parsescachedProjectsandcachedThreadsfrom localStorage and hydratesstate.projectsandstate.threadson startup, withthreadsHydrated: falseuntil the server response arrives.persistStatenow writescachedProjectsandcachedThreadsto localStorage on each state update, expanding the storage schema.syncServerReadModelcompletes.Macroscope summarized a15da82.