Add workspace open targets and Ghostty support#952
Open
copypasteitworks wants to merge 2 commits intopingdotgg:mainfrom
Open
Add workspace open targets and Ghostty support#952copypasteitworks wants to merge 2 commits intopingdotgg:mainfrom
copypasteitworks wants to merge 2 commits intopingdotgg:mainfrom
Conversation
- add shared open-target contracts and websocket methods for `shell.openWorkspace` - implement server resolution/launch logic for workspace targets, including Ghostty - update Open menu UI to list workspace targets without changing preferred editor - extend tests across contracts, server, and web for new open-target behavior
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for opening a workspace with broader open targets instead of editors only.
This PR:
shell.openWorkspacewebsocket/native API methodWorkspaceOpenTargetIdcontractsavailableOpenTargetsfrom the server configBehavior
Validation
Passed:
bun fmtbun lintbun typecheckTargeted tests passed:
bun run test src/open.test.ts src/wsServer.test.tsinapps/serverbun run test src/openTarget.test.ts src/ws.test.tsinpackages/contractsbun run test src/wsNativeApi.test.ts src/terminalStateStore.test.tsinapps/webNote
Add Ghostty terminal as a workspace open target in the Open menu
WORKSPACE_OPEN_TARGETScontract andWorkspaceOpenTargetIdtype inpackages/contracts/src/openTarget.ts, plus a newshell.openWorkspaceWebSocket method.availableOpenTargets(including Ghostty when detected) and returns it ingetConfig; a newopenWorkspaceRPC routes to theOpenservice.osascript) on macOS and theghosttyCLI on Linux; unsupported platforms return an error.OpenInPickerrenders Ghostty alongside editors, invokesshell.openWorkspacefor it, and skips updating the saved last-editor preference when Ghostty is selected.Macroscope summarized f01e46d.