Skip to content

fix(desktop): show dialog after "Check for Updates" menu action#955

Merged
juliusmarminge merged 1 commit intopingdotgg:mainfrom
dpav02:fix/check-for-updates-menu-feedback
Mar 13, 2026
Merged

fix(desktop): show dialog after "Check for Updates" menu action#955
juliusmarminge merged 1 commit intopingdotgg:mainfrom
dpav02:fix/check-for-updates-menu-feedback

Conversation

@dpav02
Copy link
Contributor

@dpav02 dpav02 commented Mar 12, 2026

Fixes #954 — also addresses the root cause behind #359, which was closed with a workaround (install from .zip instead of .dmg) that does not resolve the issue. The installation method is irrelevant — the problem is that handleCheckForUpdatesMenuClick() discards the check result, so there is no feedback path regardless of how the app was installed.

What Changed

Extracted the menu-triggered update check into checkForUpdatesFromMenu(), which awaits the result and shows a native dialog:

  • "You're up to date!" — when electron-updater reports no newer version
  • "Update check failed" — with the error detail when the check errors

The existing fire-and-forget codepath for startup/poll checks is unchanged.

Why

The sidebar rocket button only appears for actionable states (available, downloading, downloaded). The checking and up-to-date states are intentionally hidden in the sidebar, which means menu-triggered checks have no visible feedback path. Users have been reporting this as "Check for Updates does nothing" since v0.0.3 (#359). This brings the behavior in line with standard macOS conventions (VS Code, Chrome, etc.).

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • N/A — no UI changes beyond the native OS dialog
  • N/A — no animation/interaction changes

Fixes pingdotgg#954

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 12, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 95cdc734-29c7-452b-914c-e78ea0933d11

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Mar 12, 2026
@juliusmarminge
Copy link
Member

@macroscope-app review this

@macroscopeapp
Copy link

macroscopeapp bot commented Mar 13, 2026

Review complete! No issues found.

View the results here:

@juliusmarminge juliusmarminge merged commit dfd62cf into pingdotgg:main Mar 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Check for Updates…" menu action gives no feedback on macOS

2 participants