fix(desktop): show dialog after "Check for Updates" menu action#955
Conversation
Fixes pingdotgg#954 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@macroscope-app review this |
|
Review complete! No issues found. View the results here: |
Fixes #954 — also addresses the root cause behind #359, which was closed with a workaround (install from
.zipinstead of.dmg) that does not resolve the issue. The installation method is irrelevant — the problem is thathandleCheckForUpdatesMenuClick()discards the check result, so there is no feedback path regardless of how the app was installed.What Changed
Extracted the menu-triggered update check into
checkForUpdatesFromMenu(), which awaits the result and shows a native dialog:electron-updaterreports no newer versionThe existing fire-and-forget codepath for startup/poll checks is unchanged.
Why
The sidebar rocket button only appears for actionable states (
available,downloading,downloaded). Thecheckingandup-to-datestates are intentionally hidden in the sidebar, which means menu-triggered checks have no visible feedback path. Users have been reporting this as "Check for Updates does nothing" since v0.0.3 (#359). This brings the behavior in line with standard macOS conventions (VS Code, Chrome, etc.).Checklist