fix(web): prefer desktop runtime version in desktop UI#957
Open
copypasteitworks wants to merge 1 commit intopingdotgg:mainfrom
Open
fix(web): prefer desktop runtime version in desktop UI#957copypasteitworks wants to merge 1 commit intopingdotgg:mainfrom
copypasteitworks wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
176c867 to
eea2d83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #947
Follow-up to #720.
What Changed
desktopUpdateState.currentVersionoverAPP_VERSIONwhen running under ElectronuseDesktopUpdateStatehook in both the sidebar and SettingsAPP_VERSIONas the fallback for normal browser usageWhy
The desktop UI was showing the web bundle version instead of the installed desktop runtime version.
This keeps the fix scoped to display logic only. No updater behavior or install flow changed.
UI Changes
Affected UI:
Before:
After:
Validation
bun fmtbun lintbun typecheckbun run --cwd apps/web test src/hooks/useDesktopUpdateState.test.tsContext
Validation
Note
Show desktop runtime app version in sidebar and settings version display
useDesktopUpdateStatehook inuseDesktopUpdateState.ts, replacing inlineuseEffectlogic in the sidebar.resolveDisplayedAppVersionto return the runtime-reported version when running in Electron, or the build-timeAPP_VERSIONas a fallback.Sidebar.tsx) and the settings page version field (_chat.settings.tsx) to use this resolved version.Macroscope summarized eea2d83.