Skip to content

fix(web): prefer desktop runtime version in desktop UI#957

Open
copypasteitworks wants to merge 1 commit intopingdotgg:mainfrom
copypasteitworks:pr/desktop-runtime-version-clean
Open

fix(web): prefer desktop runtime version in desktop UI#957
copypasteitworks wants to merge 1 commit intopingdotgg:mainfrom
copypasteitworks:pr/desktop-runtime-version-clean

Conversation

@copypasteitworks
Copy link

@copypasteitworks copypasteitworks commented Mar 12, 2026

Closes #947

Follow-up to #720.

What Changed

  • Prefer desktopUpdateState.currentVersion over APP_VERSION when running under Electron
  • Reuse a shared useDesktopUpdateState hook in both the sidebar and Settings
  • Keep APP_VERSION as the fallback for normal browser usage

Why

The desktop UI was showing the web bundle version instead of the installed desktop runtime version.

This keeps the fix scoped to display logic only. No updater behavior or install flow changed.

UI Changes

Affected UI:

  • sidebar version tooltip
  • Settings > About

Before:

After:

  • The same UI now shows the desktop runtime's current version when running in Electron.

Validation

  • bun fmt
  • bun lint
  • bun typecheck
  • bun run --cwd apps/web test src/hooks/useDesktopUpdateState.test.ts

Context

Validation

  • This PR is small and focused
  • I explained what changed and why

Note

Show desktop runtime app version in sidebar and settings version display

  • Extracts desktop update state management into a useDesktopUpdateState hook in useDesktopUpdateState.ts, replacing inline useEffect logic in the sidebar.
  • Adds resolveDisplayedAppVersion to return the runtime-reported version when running in Electron, or the build-time APP_VERSION as a fallback.
  • Updates both the sidebar version tooltip (Sidebar.tsx) and the settings page version field (_chat.settings.tsx) to use this resolved version.

Macroscope summarized eea2d83.

@coderabbitai
Copy link

coderabbitai bot commented Mar 12, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 78e68351-810c-44b1-a121-ce6774e4c86f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Mar 12, 2026
@copypasteitworks copypasteitworks force-pushed the pr/desktop-runtime-version-clean branch from 176c867 to eea2d83 Compare March 12, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong Version number inside Settings

2 participants