fix: fix logo aligment regression on macOS#960
Open
nmggithub wants to merge 1 commit intopingdotgg:mainfrom
Open
fix: fix logo aligment regression on macOS#960nmggithub wants to merge 1 commit intopingdotgg:mainfrom
nmggithub wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This is a fix for a regression of #586. The alignment appears to have regressed at or around a6b22ec. Honestly, it would be nice to tie these things together more directly, but it's a bit of a niche thing and would likely only work with something like
position: absolute, which is its own set of issues.Why
The logo should be aligned the traffic lights on macOS (as evidenced by the original PR merging).
UI Changes
Before
After
Checklist
I included a video for animation/interaction changesNote
Fix logo alignment regression in sidebar on macOS
Removes the
mt-1.5top margin from the wordmark container div in Sidebar.tsx, restoring correct vertical positioning of the logo.Macroscope summarized fb66767.