Update bindings to compile under multiple node versions#3
Open
davidcroda wants to merge 4 commits into
Open
Conversation
Author
|
Hmm. Since this completely breaks the build on Node < 0.12 (which I should have probably anticipated) I am going to close this for now. Going to take a crack at updating it to use nan instead which I believe should handle the differences between versions. |
Author
|
Ok, redid this using nan. All tests are green on my build, hoping this fares better on Node < 0.12 |
|
+1 merge this in! |
|
I actually just got an error |
Author
|
This PR is to support Node v0.12 . You are building on Node v5.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v8 0.12 has a number of breaking changes, and this module can no longer be installed on many systems which default to node 0.12+
I updated it to the current API. It compiles on Node v0.12.5. All tests pass.
Fixes #2