tls: make sure certificates can't be read by other users#19
Open
mrl5 wants to merge 1 commit intopingooio:mainfrom
Open
tls: make sure certificates can't be read by other users#19mrl5 wants to merge 1 commit intopingooio:mainfrom
mrl5 wants to merge 1 commit intopingooio:mainfrom
Conversation
mrl5
force-pushed
the
tls-dir-permissions
branch
from
bb9ff1c to
d3f0a3c
Compare
Author
|
hmm, this PR might introduce some regression that was fixed in e2d9875 |
this change introduces additional security layer which makes sure that certificates can't be read by other linux users by using 750 directory mode
mrl5
force-pushed
the
tls-dir-permissions
branch
from
d3f0a3c to
a78345e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Currently
/etc/pingoo/tlsfolder hasdrwxr-xr-x(755) permissions. This is where certificates are stored and they are created with-rw-r--r--(644) mode.Solution
This change introduces additional security layer which makes sure that certificates can't be read by other linux users, by setting 750 directory mode (
drwxr-x---) for the/etc/pingoo/tlsdir