fix(android): Memory leak from lifecycleObserver mapView reference#97
Closed
ottor-o wants to merge 3 commits intopinpong:devfrom
Closed
fix(android): Memory leak from lifecycleObserver mapView reference#97ottor-o wants to merge 3 commits intopinpong:devfrom
ottor-o wants to merge 3 commits intopinpong:devfrom
Conversation
## [1.11.0](pinpong/react-native-google-maps-plus@v1.10.2...v1.11.0) (2026-01-27) ### ✨ Features * transit layer support ([5db65ea](pinpong@5db65ea)) ### 🐛 Bug Fixes * **podspec:** correct source_files patterns ([ffb01cb](pinpong@ffb01cb)) ### 📚 Documentation * fix warning ([417fd45](pinpong@417fd45)) * **types:** improve type documentation links ([1683bfb](pinpong@1683bfb)) ### 🛠️ Other changes * **android:** update android-maps-utils ([986c008](pinpong@986c008)) * **android:** update maps sdk ([e85acce](pinpong@e85acce)) * apply ktlint formatting ([b8f6850](pinpong@b8f6850)) * **example:** transit layer support ([b7ea377](pinpong@b7ea377)) * **ios:** update maps sdk ([63ea155](pinpong@63ea155)) * merge dev into main ([c6d58b7](pinpong@c6d58b7)) * merge dev into main ([0ebfd30](pinpong@0ebfd30)) * update dependencies ([f06ae6f](pinpong@f06ae6f)) * update dependencies ([1ebc567](pinpong@1ebc567)) * update README.md ([dc1f75f](pinpong@dc1f75f)) * update to react-native 0.83.1 ([94f7978](pinpong@94f7978))
Owner
|
Thanks for the PR, the soruce branch is currently based on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Please ensure this PR targets the
devbranch and follows the project conventions.CI already runs linting, formatting, and build checks automatically.
Before submitting
devbranch (notmain)Summary
Fixes a memory leak caused by mapView reference kept by lifecycleObserver
Type of change
Scope
Additional notes
There's a memory leak caused by lifecycleObserver apparently because if keeps a reference of mapView. Nullifying lifecycleObserver fixed it for me.
The memory leak can be observed by putting GoogleMapsView on a stack or a modal and then closing and navigating to it multiple times. The easiest way to reproduce it is to render GoogleMapsView on a flatlist a few hundred times and to scroll back and forth causing an out of memory crash.