Conversation
JoTurk
reviewed
Jun 5, 2025
Member
JoTurk
left a comment
JoTurk
left a comment
There was a problem hiding this comment.
The discord and the slack pages are used, In fact we have few links to https://pion.ly/discord/ (Sean posted it in his LinkedIn too). And we have few old links to https://pion.ly/slack (we can just add a message that we moved to discord)
Member
Author
|
Oh, I will keep them in then. |
This reverts commit e7bef70.
Merged
JoTurk
reviewed
Jun 13, 2025
Member
JoTurk
left a comment
JoTurk
left a comment
There was a problem hiding this comment.
Hello, sorry I missed this one.
So there are two minor issues:
- Running a feed validator on this XML returned few issues, (we can ignore them but they will break many RFC-compliant readers).
- can we add
<link rel="alternate" type="application/rss+xml"to the haed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, hugo generates /index.xml, which contains all routes. We only want to generate rss feed for /blog/, so this PR configures hugo to only generate /blog/index.xml, and use a custom template to include full text content in the feed.