-
Notifications
You must be signed in to change notification settings - Fork 205
ADD userguide/adding-an-app #6376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@khanhtc1202, please check! 🙌 |
| {{< tabpane >}} | ||
| {{< tab lang="yaml" header="Kubernetes Application" >}} | ||
| # For application's configuration in detail for a Kubernetes Application, please visit | ||
| # https://pipecd.dev/docs/user-guide/managing-application/defining-app-configuration/kubernetes/ | ||
|
|
||
| apiVersion: pipecd.dev/v1beta1 | ||
| kind: Application | ||
| spec: | ||
| name: foo | ||
| labels: | ||
| team: bar | ||
| {{< /tab >}} | ||
| {{< tab lang="yaml" header="Terraform Application" >}} | ||
|
|
||
| # For application's configuration in detail for Terraform Application, please visit | ||
| # https://pipecd.dev/docs/user-guide/managing-application/defining-app-configuration/terraform/ | ||
|
|
||
| apiVersion: pipecd.dev/v1beta1 | ||
| kind: Application | ||
| spec: | ||
| name: foo | ||
| labels: | ||
| team: bar | ||
| {{< /tab >}} | ||
| {{< /tabpane >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about to make prepare piped plugins for your application docs separately and mention it here as pre-require for this docs 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? If you want me to add something like a “Prerequisites” section here and link to separate docs about preparing PipeCD plugins?
Or do you mean something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? If you want me to add something like a “Prerequisites” section here and link to separate docs about preparing PipeCD plugins?
Yes, this is what I mean 👀
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
c79a3a6 to
ed7afd4
Compare
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
|
Changges done, please check, @khanhtc1202, Thanks! Happy Holidays! 🎄 |
What this PR does: Add managing-application/adding-an-application
File by file commit from the bigger PR - #6345
Why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: