-
Notifications
You must be signed in to change notification settings - Fork 208
docs(contributing): expand contribution guidelines with new sections #6399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
docs(contributing): expand contribution guidelines with new sections #6399
Conversation
…and details Signed-off-by: Mohammed Firdous <mohammedfirdousaraoye@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
eeshaanSA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for this @mohammedfirdouss!
I checked the files, and while they look good, what do you think of making some more structural changes (better flow of data and sections), and also some more info on how to setup the a local dev guide? The reference to CONTRIBUTING.md is fine, but the CONTRIBUTING.md itself is outdated, so it is better to just have all the information in one page on the website.
Thanks for the feedback @eeshan! Hmm, Okay the website docs page should be self-contained rather than referencing CONTRIBUTING.md. TO-DO
@eeshaanSA This should address the issue already yeah? I am open to feedbacks |
…ty engagement details Signed-off-by: Mohammed Firdous <mohammedfirdousaraoye@gmail.com>
eeshaanSA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @mohammedfirdouss.
Thanks a lot for your contributions! 🚀
Thank you for the reviews as well @eeshaanSA. Ready for more contributions! |
Addresses #6124