fix(data): DEFAULT CURRENT_TIMESTAMP on CreatedAt/ModifiedAt#651
Merged
fix(data): DEFAULT CURRENT_TIMESTAMP on CreatedAt/ModifiedAt#651
Conversation
…iedAt Follow-up to v1.94.5. Tagging the columns NOT NULL alone broke raw-SQL seed migrations that INSERT without specifying created_at/modified_at (hand-written tenant/partition/client seeds). Adding a column DEFAULT keeps those seeds working while preserving the NOT NULL invariant BeforeCreate already enforces for GORM-driven writes. PostgreSQL uses CURRENT_TIMESTAMP; MySQL/SQLite accept the same literal verbatim as a default expression.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the BaseModel struct in data/model.go by adding default:CURRENT_TIMESTAMP to the CreatedAt and ModifiedAt fields. This change ensures that these columns are correctly populated during raw SQL seed inserts and prevents GORM's AutoMigrate from relaxing column constraints. I have no feedback to provide as no review comments were submitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to v1.94.5. Tagging NOT NULL alone broke raw SQL seed migrations that INSERT without specifying created_at/modified_at (tenant/partition/client seeds). Adding a column DEFAULT keeps those seeds working while preserving the NOT NULL invariant.