Implementing to do list#1
Open
pjuhel wants to merge 5 commits into
Open
Conversation
Starting fresh to create the todolist
Creating TodoList and TodoListItem component, displaying them in the app with a default state
Basic todolist, ability to add items to an existing list.
Changing syntax to be more newcomer friendly, especially destructuration occurences.
Implement a delete button. Each item in the list now bear a unique Id for identifying purposes.
louis-bompart
left a comment
louis-bompart
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, few suggestions to make it even betta
Comment on lines
+23
to
+29
| if (todo === selectedTodo) { | ||
| return { | ||
| ...todo, | ||
| complete: !todo.complete, | ||
| }; | ||
| } | ||
| return todo; |
Collaborator
There was a problem hiding this comment.
Here, I would recommend the uses of a ternary
Suggested change
| if (todo === selectedTodo) { | |
| return { | |
| ...todo, | |
| complete: !todo.complete, | |
| }; | |
| } | |
| return todo; | |
| return { | |
| ...todo, | |
| complete: todo === selectedTodo ? !todo.complete : todo.complete | |
| }; |
| } | ||
|
|
||
| export const AddTodoForm: React.FC<Props> = (param) => { | ||
| //const { addTodo } = param; |
Collaborator
There was a problem hiding this comment.
Don't leave commented code, it's dirty :P
If you leave it for documentation purposes, I'd advise you to put an actual comment with it.
Owner
Author
There was a problem hiding this comment.
I shall make a documentation of it. I wanted to keep track of the possible destructuration here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First version of the TodoList program. Complete with add/delete functionnalities.