Add suport for fonts with 224 characters#340
Open
KiliLoje wants to merge 9 commits intopk-hack:masterfrom
Open
Add suport for fonts with 224 characters#340KiliLoje wants to merge 9 commits intopk-hack:masterfrom
KiliLoje wants to merge 9 commits intopk-hack:masterfrom
Conversation
…NT_IMAGE_ARRANGEMENT_224
…rice to the patch
Author
|
I just wanted to add that a lot of credits for this goes to people in the Pk-hack discord servers that helped me figure things out, explained to me what I should search for exactly, explained to me coilsnake's architecture, and many more things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this adds support to fonts with 224 characters by doing a bunch of patching in
coilsnake/modules/eb/FontModule.py::write_to_rom().I made the code as readable as possible. I hope we can work toward merging this fork with the repo.