Repository navigation
CI: Run Check Updates on merge_group - #679
Merged
Merged
Conversation
Queue branches should exercise the nvchecker run like any other check, but never open update PRs from a gh-readonly-queue ref. Signed-off-by: Prasanth Baskar <prasanth@8gears.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Merge-group execution must use a separate read-only job or workflow.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Adds merge-queue support to the package update workflow while preventing queued runs from creating pull requests.
Changes:
- Adds the
merge_grouptrigger. - Skips pull-request creation for merge-group runs.
- Identifies a critical token-permission risk requiring workflow separation.
| File | Summary |
|---|---|
.github/workflows/check_updates.yml |
Merge-group runs execute repository-controlled code with write-capable permissions, creating a potential GITHUB_TOKEN exfiltration risk. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| branches: [main] | ||
| pull_request: | ||
| branches: [main] | ||
| merge_group: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #678. Adds
merge_group:trigger tocheck_updates.ymlso every workflow runs on queue branches. The Create Pull Request step is skipped onmerge_groupso queue runs never open update PRs.🤖 Generated with Claude Code