Repository navigation
Add per-deploy-request aggressive cutover - #1466
Draft
mscoutermarsh wants to merge 1 commit into
Draft
mscoutermarsh wants to merge 1 commit into
mscoutermarsh wants to merge 1 commit into
Conversation
Opt a single Vitess deploy request into aggressive cutover from create and update, and show the flag on human show and queue tables. Co-authored-by: Mike Coutermarsh <coutermarsh.mike@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opt a single Vitess deploy request into aggressive cutover without changing the database setting or other deploy requests.
pscale deploy-request create --aggressive-cutoversendsaggressive_cutover: trueonly when the flag is set.pscale deploy-request update --aggressive-cutoverand--aggressive-cutover=falsePUT .../deploy-requests/:number/aggressive-cutoverwith{ "enable": <bool> }. Unset flags are not sent.showandqueuehuman tables include anaggressive_cutovercolumn. JSON output already prints the deployment field from the API object.AGENTS.mddocuments the flags next to the other deploy-request commands.Database
aggressive-cutoveranddeploy-request force-cutoverare unchanged. There is no confirmation prompt.Test plan
go test ./internal/cmd/deployrequest/ ./internal/planetscale/ -count=1--aggressive-cutoveragainst an API that accepts the field and confirmdeployment.aggressive_cutoveris true--aggressive-cutover=falsewhile the request is still editable, then again after submission and confirm the 422 is printed