Skip to content

Fix target-clean.sh dynamic SQL quoting #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teknogeek0 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix target-clean.sh dynamic SQL quoting #49

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a8d454
Fix target-clean.sh to use quote_ident for all dynamic DROP statements
teknogeek0 Apr 29, 2026
999123d
Add publications count to target-clean.sh summary
teknogeek0 Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions pgcopydb-helpers/target-clean.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ WHERE n.nspname NOT IN ('pg_catalog','information_schema','pscale_extensions')
AND p.prokind = 'a'
AND NOT EXISTS (SELECT 1 FROM pg_depend d WHERE d.objid = p.oid AND d.deptype = 'e');"

psql "$PGCOPYDB_TARGET_PGURI" --no-align -t -c "
SELECT 'Publications: ' || count(*)
FROM pg_publication;"

psql "$PGCOPYDB_TARGET_PGURI" --no-align -t -c "
SELECT 'Extensions: ' || count(*)
FROM pg_extension WHERE extname != 'plpgsql';"
Expand Down Expand Up @@ -121,12 +125,12 @@ echo "Cleaning..."

echo " Dropping materialized views..."
psql "$PGCOPYDB_TARGET_PGURI" -t -c "
SELECT 'DROP MATERIALIZED VIEW IF EXISTS ' || schemaname || '.' || matviewname || ' CASCADE;'
SELECT 'DROP MATERIALIZED VIEW IF EXISTS ' || quote_ident(schemaname) || '.' || quote_ident(matviewname) || ' CASCADE;'
FROM pg_matviews;" | psql "$PGCOPYDB_TARGET_PGURI" 2>/dev/null || true

echo " Dropping views (non-extension-owned)..."
psql "$PGCOPYDB_TARGET_PGURI" -t -c "
SELECT 'DROP VIEW IF EXISTS ' || schemaname || '.\"' || viewname || '\" CASCADE;'
SELECT 'DROP VIEW IF EXISTS ' || quote_ident(schemaname) || '.' || quote_ident(viewname) || ' CASCADE;'
FROM pg_views
WHERE schemaname NOT IN ('pg_catalog','information_schema')
AND NOT EXISTS (
Expand All @@ -138,18 +142,22 @@ WHERE schemaname NOT IN ('pg_catalog','information_schema')
) AND d.deptype = 'e'
);" | psql "$PGCOPYDB_TARGET_PGURI" 2>/dev/null || true

echo " Dropping publications/subscriptions..."
psql "$PGCOPYDB_TARGET_PGURI" -c "DROP PUBLICATION IF EXISTS pgcopydb_pub CASCADE;" 2>/dev/null || true
psql "$PGCOPYDB_TARGET_PGURI" -c "DROP SUBSCRIPTION IF EXISTS pgcopydb_sub CASCADE;" 2>/dev/null || true
echo " Dropping all publications and subscriptions..."
psql "$PGCOPYDB_TARGET_PGURI" -t -c "
SELECT 'DROP PUBLICATION IF EXISTS ' || quote_ident(pubname) || ' CASCADE;'
FROM pg_publication;" | psql "$PGCOPYDB_TARGET_PGURI" 2>/dev/null || true
psql "$PGCOPYDB_TARGET_PGURI" -t -c "
SELECT 'DROP SUBSCRIPTION IF EXISTS ' || quote_ident(subname) || ' CASCADE;'
FROM pg_subscription;" | psql "$PGCOPYDB_TARGET_PGURI" 2>/dev/null || true

echo " Dropping event triggers..."
psql "$PGCOPYDB_TARGET_PGURI" -t -c "
SELECT 'DROP EVENT TRIGGER IF EXISTS ' || evtname || ' CASCADE;'
SELECT 'DROP EVENT TRIGGER IF EXISTS ' || quote_ident(evtname) || ' CASCADE;'
FROM pg_event_trigger;" | psql "$PGCOPYDB_TARGET_PGURI" 2>/dev/null || true

echo " Dropping non-extension-owned aggregates..."
psql "$PGCOPYDB_TARGET_PGURI" -t -c "
SELECT 'DROP AGGREGATE IF EXISTS ' || n.nspname || '.\"' || p.proname || '\"('
SELECT 'DROP AGGREGATE IF EXISTS ' || quote_ident(n.nspname) || '.' || quote_ident(p.proname) || '('
|| pg_get_function_identity_arguments(p.oid) || ') CASCADE;'
FROM pg_proc p
JOIN pg_namespace n ON p.pronamespace = n.oid
Expand All @@ -160,7 +168,7 @@ WHERE n.nspname NOT IN ('pg_catalog','information_schema','pscale_extensions')

echo " Dropping non-extension-owned functions..."
psql "$PGCOPYDB_TARGET_PGURI" -t -c "
SELECT 'DROP FUNCTION IF EXISTS ' || n.nspname || '.\"' || p.proname || '\"('
SELECT 'DROP FUNCTION IF EXISTS ' || quote_ident(n.nspname) || '.' || quote_ident(p.proname) || '('
|| pg_get_function_identity_arguments(p.oid) || ') CASCADE;'
FROM pg_proc p
JOIN pg_namespace n ON p.pronamespace = n.oid
Expand All @@ -171,7 +179,7 @@ WHERE n.nspname NOT IN ('pg_catalog','information_schema','pscale_extensions')

echo " Dropping non-extension-owned procedures..."
psql "$PGCOPYDB_TARGET_PGURI" -t -c "
SELECT 'DROP PROCEDURE IF EXISTS ' || n.nspname || '.\"' || p.proname || '\"('
SELECT 'DROP PROCEDURE IF EXISTS ' || quote_ident(n.nspname) || '.' || quote_ident(p.proname) || '('
|| pg_get_function_identity_arguments(p.oid) || ') CASCADE;'
FROM pg_proc p
JOIN pg_namespace n ON p.pronamespace = n.oid
Expand All @@ -182,7 +190,7 @@ WHERE n.nspname NOT IN ('pg_catalog','information_schema','pscale_extensions')

echo " Dropping standalone custom types (enums + composites)..."
psql "$PGCOPYDB_TARGET_PGURI" -t -c "
SELECT 'DROP TYPE IF EXISTS ' || n.nspname || '.\"' || t.typname || '\" CASCADE;'
SELECT 'DROP TYPE IF EXISTS ' || quote_ident(n.nspname) || '.' || quote_ident(t.typname) || ' CASCADE;'
FROM pg_type t
JOIN pg_namespace n ON t.typnamespace = n.oid
WHERE t.typtype IN ('c', 'e')
Expand All @@ -193,7 +201,7 @@ ORDER BY n.nspname, t.typname;" | psql "$PGCOPYDB_TARGET_PGURI" 2>/dev/null || t

echo " Dropping non-default schemas (excluding extension-owned)..."
psql "$PGCOPYDB_TARGET_PGURI" -t -c "
SELECT 'DROP SCHEMA IF EXISTS ' || n.nspname || ' CASCADE;'
SELECT 'DROP SCHEMA IF EXISTS ' || quote_ident(n.nspname) || ' CASCADE;'
FROM pg_namespace n
WHERE n.nspname NOT IN ('pg_catalog','information_schema','pg_toast','public','pscale_extensions')
AND n.nspname NOT LIKE 'pg_temp%' AND n.nspname NOT LIKE 'pg_toast_temp%'
Expand All @@ -202,7 +210,7 @@ WHERE n.nspname NOT IN ('pg_catalog','information_schema','pg_toast','public','p

echo " Dropping partitioned tables in public..."
psql "$PGCOPYDB_TARGET_PGURI" -t -c "
SELECT 'DROP TABLE IF EXISTS public.\"' || relname || '\" CASCADE;'
SELECT 'DROP TABLE IF EXISTS public.' || quote_ident(relname) || ' CASCADE;'
FROM pg_class
WHERE relkind = 'p'
AND relnamespace = (SELECT oid FROM pg_namespace WHERE nspname = 'public')
Expand Down