Repository navigation
fix(keys): a plain binding no longer answers with Ctrl held - #132
Open
sebastianst wants to merge 1 commit into
Open
sebastianst wants to merge 1 commit into
sebastianst wants to merge 1 commit into
Conversation
Ctrl+X cleared a block and Ctrl+Q quit, because plain bindings only needed the key code to match. Shift still passes, as shifted letters need it, and Ctrl with Alt too, which is how Windows reports AltGr. Ctrl+P keeps meaning p in a review with no file tree, now by looking the key up without Ctrl. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverses a default that a test pinned: a plain binding no longer answers with Ctrl held, so
a_plain_binding_still_answers_ctrl_when_no_ctrl_binding_claims_itis replaced. Happy to drop this if the old behaviour is deliberate.Today
Ctrl+Xclears a block andCtrl+Qquits, because a plain binding only needs the key code to match, which makes a slip costly.AltGrthat way.Ctrl+Pkeeps meaningpin a review with no file tree, now explicitly.🤖 Co-created with Claude Opus 5.5