Repository navigation
fix(ui): footer key hints flow onto up to three rows - #134
Draft
sebastianst wants to merge 7 commits into
Draft
sebastianst wants to merge 7 commits into
sebastianst wants to merge 7 commits into
Conversation
`e` moves to a word's last character and `V` selects whole rows. `a` and `d` now mark the selected block without going through a selection. Leaving a block comment no longer leaves a toolbar behind: block `c` made a pending selection for the box and Esc kept it, which is why `a` and `d` only appeared after a cancelled comment. `a` and `d` on a block sit outside the keymap's conflict check, so a config that gave those keys to a document action keeps loading and keeps its key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
w, b and e indexed a row by character while the cursor is in screen columns, so they landed short on rows with wide characters. w and b also missed a word after a non-ASCII space such as U+3000. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pressing a or d twice added two identical notes, and both were sent to the agent. The status now says the mark is already saved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Enter still opens the toolbar, and a motion bound to one of these keys still moves. A key that does nothing during a mouse drag no longer collapses the selection, and a selection that never moved no longer leaves its visual hint in the footer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Like a, c and d, the copy key now finishes a selection still being extended. The text stays selected, as it does when copying from the toolbar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A plain binding answers with Ctrl held, which would make Ctrl+A mark a block and Ctrl+D mark a selection instead of paging. These new surfaces ignore such a press, while a mark bound to a Ctrl key still fires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hints that didn't fit ran into the file and status text. They now move to rows above it, at most three in total, and the document keeps what the keys act on in view when the footer grows. A text box shows no hints, since it takes every key and its border names the ones it answers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft because it's stacked on #133. A PR from a fork can't target another branch on that fork, so this has to target
mainand also shows #133's commits. Only the last commit is new: review just that diff. I'll rebase and mark this ready once #133 lands.Key hints no longer get cut off in a narrow pane or next to a long status: the footer flows onto up to three rows, growing upward.
🤖 Co-created with Claude Opus 5.5