Exploration rate limit#6337
Merged
Merged
Conversation
aerosol
commented
May 11, 2026
|
aerosol
force-pushed
the
exploration-rate-limit
branch
from
ebb2374 to
b3f669a
Compare
zoldar
reviewed
May 12, 2026
Contributor
|
It would be good to explicitly handle rate limit violation when querying for featured funnel (can be reproduced by rapidly refreshing dashaboard with "Explore" tab open by default): 
|
aerosol
force-pushed
the
exploration-rate-limit
branch
from
9fc997e to
08c5801
Compare
zoldar
approved these changes
May 12, 2026
Contributor
zoldar
left a comment
zoldar
left a comment
There was a problem hiding this comment.
Working well now, as far as I could abuse test it 👌 LGTM (just needs a provisional @moduledoc in touched API helper module to make credo happy).
Contributor
|
Ugh, sorry, my patch introduced a conflict 🙈 I'll fix it up in a bit and fix that credo complaint btw |
zoldar
force-pushed
the
exploration-rate-limit
branch
from
bd8f3a4 to
f5f0ccc
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
ApiErrorto store http status so the details can be reliably inspected for extra error handling