Return explicit journey end event#6340
Merged
Merged
Conversation
|
zoldar
force-pushed
the
exploration-no-further-action
branch
2 times, most recently
from
fa1b1c1 to
ccb56d8
Compare
zoldar
force-pushed
the
exploration-no-further-action
branch
from
ccb56d8 to
e7f3dc7
Compare
|
zoldar
force-pushed
the
exploration-no-further-action
branch
from
e7f3dc7 to
722c6a9
Compare
aerosol
approved these changes
May 12, 2026
Member
aerosol
left a comment
aerosol
left a comment
There was a problem hiding this comment.
Approach is fine, but we'll have to tweak it visually most likely once @sanne-san is back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR implements explicit listing of journey end. It's currently displayed like any other item among the suggestions, subject to the same sorting order and limit of number of displayed entries (if it's small enough, it won't make it to the list).
The visual representation might be improved in follow-up work (dedicated icon? some behavior on click?).
Tests