fixing issue with infinite scroll and a row count of 0#454
Merged
BSd3v merged 9 commits intoplotly:v35from Apr 22, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes an infinite-row-model edge case where setting rowCount to 0 (e.g., clearing the grid) prevents subsequent data from rendering when new rows are later provided.
Changes:
- Add a regression test that clears infinite-scroll data (
rowCount=0) and then resets it. - Update the infinite scrolling datasource response handler to attempt to recover from prior
rowCount=0state. - Document the fix in the changelog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/test_infinite_scroll.py | Adds a regression test covering “clear to 0 rows then reset to data” behavior. |
| src/lib/fragments/AgGrid.react.js | Modifies infinite scrolling response handling to handle transitions from rowCount=0. |
| CHANGELOG.md | Adds an unreleased “Fixed” entry describing the rowCount=0 rendering issue. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AnnMarieW
approved these changes
Apr 22, 2026
Collaborator
AnnMarieW
left a comment
AnnMarieW
left a comment
There was a problem hiding this comment.
Looks like a good workaround. The comments are helpful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.