Bugfix: Fix no context in catchall route#3819
Open
KoolADE85 wants to merge 1 commit into
Open
Conversation
|
Contributor
|
We have another PR #3815 that also fixes for quart but doesn't use the provided set_current_request, I think set_current_request is valid but maybe both solutions should be consolidated. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a 500
RuntimeError: No active request in contextthat breaks custom paths which fall through to the catch-all route.The catch-all view already receives the request, but we ignored it. This PR registers it into the request context for the duration of the render, mirroring how we handle Dash routes themselves.
Fixes #3812
Contributor Checklist
optionals
CHANGELOG.md