Repository navigation
fix: Prevent race condition by enabling page events before navigation - #482
Merged
Merged
Conversation
dennisjlee
force-pushed
the
fix/enablePageBeforeNavigate
branch
from
October 19, 2026 19:39
7c4ef58 to
9716368
Compare
Contributor
|
I'll review this and follow up. |
Contributor
Author
|
@camdecoster just wanted to check in on this if you have some time! |
camdecoster
reviewed
Oct 31, 2026
camdecoster
left a comment
camdecoster
left a comment
Contributor
There was a problem hiding this comment.
This looks fine to me (and might also fix #441). Could you please add an entry to the changelog? With that, I can approve.
Contributor
Author
|
@camdecoster thanks! I updated the changelog. |
camdecoster
approved these changes
Nov 1, 2026
camdecoster
changed the title
t-0hmura
added a commit
to t-0hmura/pdb2reaction
that referenced
this pull request
Nov 6, 2026
- PNG export: wrap Kaleido's tab navigation so that it sends Page.enable first, for every Kaleido 1.x; the version check is gone. With the upstream fix (plotly/kaleido#482) the extra Page.enable is harmless. - Colab notebooks: install the latest plotly, Kaleido and choreographer instead of pinning Kaleido 1.2.0 and choreographer 1.2.1, and draw the setup check PNG with the package's PNG writer. - Tests: drop the version-check test; the setup check test looks for the package's PNG writer. - CHANGELOG: the PNG export entry no longer limits the fix to Kaleido 1.5.0 and older; the Colab change is listed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HRWQuZ3S6rn5MmsNyA2Mpv
t-0hmura
added a commit
to t-0hmura/mlmm_toolkit
that referenced
this pull request
Nov 6, 2026
- PNG export: wrap Kaleido's tab navigation so that it sends Page.enable first, for every Kaleido 1.x; the version check is gone. With the upstream fix (plotly/kaleido#482) the extra Page.enable is harmless. - Colab notebooks: install the latest plotly, Kaleido and choreographer instead of pinning Kaleido 1.2.0 and choreographer 1.2.1, and draw the setup check PNG with the package's PNG writer. - Tests: drop the version-check test; the setup check test looks for the package's PNG writer. - CHANGELOG: the PNG export entry no longer limits the fix to Kaleido 1.5.0 and older; the Colab change is listed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HRWQuZ3S6rn5MmsNyA2Mpv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #481
Note on why the fix works:
Page.enableenables page notifications, but doesn’t promise to replay a previousPage.loadEventFired. Chromium’s implementation enables the agent without replaying that event.