Skip to content

PR : Fix responsible group visibility after injection#607

Open
Neu-Maximilian wants to merge 2 commits intopluginsGLPI:mainfrom
Neu-Maximilian:hotfix/responsible-group-visibility
Open

PR : Fix responsible group visibility after injection#607
Neu-Maximilian wants to merge 2 commits intopluginsGLPI:mainfrom
Neu-Maximilian:hotfix/responsible-group-visibility

Conversation

@Neu-Maximilian
Copy link
Copy Markdown

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes Responsible group injection visibility issue #606
  • Normalize groups_id, groups_id_normal, and groups_id_tech to the GLPI relation payload keys expected by equipment save flows
  • Preserve technical-group handling with _groups_id_tech
  • Fall back to key-based normalization when search option join metadata is incomplete
  • Add an unreleased changelog entry

Copilot AI review requested due to automatic review settings April 17, 2026 08:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses GLPI equipment “responsible group” visibility after DataInjection imports (#606) by normalizing injected group fields into the relation payload keys GLPI expects during save flows.

Changes:

  • Normalize groups_id, groups_id_normal, and groups_id_tech into _groups_id / _groups_id_tech arrays during injection.
  • Preserve technical-group handling via key-based and metadata-based detection.
  • Add an Unreleased changelog entry describing the fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
inc/commoninjectionlib.class.php Normalizes injected group assignment fields to GLPI’s expected relation payload keys to keep groups UI-visible after import.
CHANGELOG.md Documents the fix under the Unreleased “Fixed” section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread inc/commoninjectionlib.class.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Responsible group injection visibility issue

2 participants