Repository navigation
test(config): pin typo-port refusal and key-file permission warn - #397
Merged
Merged
Conversation
A written port that is not a u16 (host:, host:99999, host:abc) parses with port_u16() == None and would match any port; the entry.len() > host.len() arm refuses it at startup. > mangled to < or ==, and the : check flipped to !=, accept the typo instead (>= is identical, documented in DESIGN.md). The key-file mode warn fires exactly for group/other-readable files: & mangled to | or ^ warns on 0600 too, != mangled to == warns on 0600 only. DESIGN.md Testing records both pins plus the documented-not-tested dispositions (custom-fields contains(',') collapse, stdio delimiter advance). Guards touched: host validation strictness kept fail-closed, I12 (key never logged).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourteenth artifact of the mutation-testing campaign (remaining files): typo ports are refused as startup errors (not parsed hostnames), and key files readable by group or others warn exactly on the wide files — with the other-writable bit pinned too, and the temp files in an auto-cleaned dir. The comma-guard and
>=survivors proved behaviorally identical and stay documented. No production behavior changed — tests and prose only. Verified: fmt, clippy-D warnings, full suite, per-mutant kill matrix, native OCR clean (including a second pass that caught temp-file hygiene — fixed before opening).