Fix Chrome prefetch main_frame & outermost_frame#70
Open
agoodkind wants to merge 2 commits intopmarks-net:masterfrom
Open
Fix Chrome prefetch main_frame & outermost_frame#70agoodkind wants to merge 2 commits intopmarks-net:masterfrom
agoodkind wants to merge 2 commits intopmarks-net:masterfrom
Conversation
Author
|
@pmarks-net This fixes #71 |
Owner
|
I found a preliminary solution. It's called from the same places as Demo: https://www.google.com/search?q=real+estate IPvFoo shows "www.realtor.com 2001:4860:4802:34::9d" and "www.zillow.com 2001:4860:4802:34::9d", which suggests that the requests are being proxied by Google. I should probably add a P/prefetch icon next to the address, because otherwise the results could be misleading. Neither of those sites actually support IPv6. |
00b54be to
0fd3d6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added two new functions:
getTrueTabDomain(tabId)- Fetches the actual domain from the tab's URL (source of truth from the address bar)isMainTabUrl(details)- Validates if a request is truly for the main frame by comparing the request's domain against the tab's actual domainModified two locations:
chrome.webRequest.onBeforeRequest- Replaced simple type check withawait isMainTabUrl(details)chrome.webRequest.onBeforeRedirect- Replaced simple type check withawait isMainTabUrl(details)What this fixes
When Chrome prefetches links, it sends requests with
type: "main_frame", which previously causedmainDomainto be overwritten incorrectly. The fix validates that the request's domain matches the tab's actual URL before treating it as a main frame navigation, preventing prefetch requests from corrupting the extension's state.Before:
Screen.Recording.2025-10-18.at.21.07.29.mov
After:
Screen.Recording.2025-10-18.at.21.18.05.mov