feat: decouple email delivery with application events, asynchronous execution, and Resilience4j retries - #39
Merged
Merged
Conversation
…t for new constructors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the notification delivery layer by decoupling mail operations from HTTP request threads using Spring Application Events and asynchronous processing. It also adds Resilience4j fault tolerance to handle transient SMTP delivery failures without blocking client workflows.
Key Changes
Event-Driven Architecture & Decoupling:
VerificationEmailRequestedEventandPasswordResetEmailRequestedEventdomain events to represent mail requests cleanly.MailServicedirectly, eliminating tight coupling.Asynchronous Execution & Resilience:
MailEventListenerto handle mail dispatch asynchronously post-transaction commit (@TransactionalEventListener), preventing email delivery latency from delaying HTTP responses.mailTaskExecutorbean and enabled@Asyncsupport for isolated concurrency management.Test Suite Updates:
MailServiceImplTestandVerificationServiceImplTestto reflect event publication logic and addedMailEventListenerTestto cover event listener behavior and retries.