Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, @pollockjj .
Currently, the node wrappers deep copy the inputs and edit them, adding more optional parameters.
I believe this is too aggressive. It breaks connectivity with folder_paths lists, which means the multigpu nodes' input folders can no longer be updated on the fly like regular unet / checkpoint etc (I wrote an extension which does that since models are on separate drives, not sure if comfy offers a similar functionality out of box).
Since it seems the only reason to create a copy in the first place is only to add more opt parms, rather than modify the existing ones in any way, a copy of the inputs + optional dicts is sufficient for the desired effect without breaking anything.