clean up linting, ignores, and precommit workflow - #8
Merged
Conversation
skyegalaxy
reviewed
Aug 13, 2026
| filter=-runtime/references | ||
|
|
||
| # Catch2 idiom is `CHECK(a == b)` with expression decomposition; CHECK_EQ is a gtest macro and not applicable here | ||
| filter=-readability/check |
Member
There was a problem hiding this comment.
this has annoyed me enough in our other catch2 repos that we ought to consider checking it into polymath_code_standard (cc @emersonknapp)
alternatively, I get the linter to stop complaining by replacing CHECK with REQUIRE (claude always likes to do CHECK for some reason)
Contributor
Author
There was a problem hiding this comment.
Yeah I generally just switch to REQUIRE but this felt fine
skyegalaxy
approved these changes
Aug 13, 2026
Member
|
todo for me: fix rolling CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: clean up linting, ignores, and precommit workflow
zeerekahmad/lint-precommit-cleanupmaine6675edDescription
Lint configuration, ignore files and the pre-commit CI workflow, ahead of the v0.2.0 kinematics work.
Migration Guide
N/A — no customer-facing behavior changes.
Related issues
Completeness checklist
Stack created with GitHub Stacks CLI • Give Feedback 💬