Align hosted Foundry Memory update behavior - #2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the TypeScript hosted Foundry Memory sample to avoid waiting on memory extraction as part of the request lifecycle, aligning runtime behavior and documentation with the .NET hosted-agent sample.
Changes:
- Removed the request-level middleware that awaited
FoundryMemoryProvider.whenUpdatesCompleted()after agent runs (including streaming). - Updated the local-scope error guidance to clarify when
x-agent-user-idis expected and how it’s injected in Foundry. - Revised README guidance to reflect asynchronous extraction (including a short delay before verifying newly taught memories) and clarified the per-user scoping equivalence to .NET.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| samples/typescript/hosted-agents/agent-framework/responses/13-foundry-memory/src/main.ts | Removes the memory-update wait middleware so extraction stays off the response path; updates the missing-user-scope error message. |
| samples/typescript/hosted-agents/agent-framework/responses/13-foundry-memory/README.md | Aligns documentation and examples with asynchronous memory extraction and .NET scoping semantics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the request-level memory update wait middleware from the TypeScript hosted sample, keeps asynchronous extraction off the response path, and aligns the documentation with the .NET hosted sample. Validation: npm run typecheck and npm run build.