Skip to content

fix(sdk): enforce canonical credential grammar - #11

Merged
purpshell merged 1 commit into
devfrom
codex/strict-v1-credential-grammar
Sep 8, 2026
Merged

fix(sdk): enforce canonical credential grammar#11
purpshell merged 1 commit into
devfrom
codex/strict-v1-credential-grammar

Conversation

@purpshell

@purpshell purpshell commented Sep 8, 2026

Copy link
Copy Markdown
Member

Summary

  • validate organization keys as exactly pmfa_ plus 72 unpadded base64url characters
  • validate project tokens as exactly pmfa_pt_ plus 94 unpadded base64url characters
  • reject listener, browser, call-agent, socket-ticket, and simulated-device credentials before transport
  • update SDK documentation and all server-client fixtures to use canonical synthetic v1 credentials

Verification

  • formatting, ESLint, strict TypeScript, all workspace builds, and core build pass
  • 66 test files / 404 tests pass, including zero-fetch malformed and special credential cases and clean packed consumers
  • strict coverage: 402 operations, 274 covered, 128 excluded, zero missing, partial, or changed
  • package dry-run: 256 files, 119,365 bytes packed, 679,563 bytes unpacked
  • production audit: 0 vulnerabilities

Video

Not applicable: this is a credential-validation hardening fix and introduces no user-facing feature workflow.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T11:26:48.931534Z 0bf6fd7 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/typescript/test/platform.test.ts

ESLint failed to execute (timeout).

packages/typescript/test/presence.test.ts

ESLint skipped: the matched ESLint configuration already failed (timeout).

packages/typescript/test/privacy.test.ts

ESLint skipped: the matched ESLint configuration already failed (timeout).

  • 5 others

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc391e6d0d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/typescript/src/credentials.ts Outdated
@purpshell
purpshell force-pushed the codex/strict-v1-credential-grammar branch from cc391e6 to 0bf6fd7 Compare September 8, 2026 11:21
@purpshell

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 0bf6fd74e7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@purpshell
purpshell merged commit 1b99aef into dev Sep 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant