fix: activate stacked windows without redundant raising - #1825
Open
philip-sterne wants to merge 1 commit into
Open
fix: activate stacked windows without redundant raising#1825philip-sterne wants to merge 1 commit into
philip-sterne wants to merge 1 commit into
Conversation
philip-sterne
marked this pull request as ready for review
August 13, 2026 10:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack.activate()own tab visibility and styling updates.Meta.Window.raise()afteractivate_with_focus().Root cause
The tab click handler changed Pop Shell's active-window state and hid the previous actor before confirming that the selected window actor could be activated. It then explicitly raised a window that Mutter had already focused. This could leave compositor stacking and Pop Shell's stack state temporarily out of sync, producing
meta_window_set_stack_position_no_syncassertions and unreliable tab activation.Impact
Stack tab clicks now follow one activation sequence and avoid the redundant stacking operation.
This is independent of #1824, which prevents DING's desktop surface from entering the normal window/focus path. It was field-tested in a Wayland session that also contained #1824.
Testing
make compile