fix: ignore no-op stack resize grabs - #1826
Open
philip-sterne wants to merge 1 commit into
Open
Conversation
philip-sterne
marked this pull request as ready for review
August 13, 2026 10:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Movement.calculate().Root cause
Pop Shell records the raw window frame when a resize grab begins. For stacked windows, the grab-end path added the tab strip to the ending rectangle before comparing it with that raw starting frame. An edge click with no actual resize therefore appeared to be an upward grow operation.
The no-movement branch also compared the starting height with the ending width. Even when
Movement.NONEwas returned, it was accepted as valid and reachedforest.resize(), where it followed the grow path.Impact
Clicking a stack's resize edge without dragging no longer shrinks the stack or reflows neighboring tiled windows. Actual directional resize operations retain their existing behavior.
This resize-grab path is independent of #1824's DING desktop-window detection and focus handling.
Testing
make compileMovement.calculate()checks for unchanged, upward-grow, and downward-grow rectangles.