feat: resolve the sandbox API base URL automatically - #2
Closed
jackowfish wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closing - re-doing this so the SDK resolves project + cluster server-side from the API key instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same change as porter-dev/porter-python-sdk#2, for the TypeScript SDK.
resolveConfigprefers an explicitbaseUrlorPORTER_SANDBOX_BASE_URL, then builds the external Porter API URL fromPORTER_PROJECT_ID+PORTER_CLUSTER_ID, then falls back to the in-cluster service URL whenKUBERNETES_SERVICE_HOSTindicates we're in a cluster.When nothing resolves, or the external URL is used without an API token, it throws an error saying which env vars to set rather than letting requests fail against an unreachable
cluster.localaddress.