complete: add SetExitFunc() to override os.Exit in tests#147
Open
charlievieth wants to merge 1 commit intoposener:masterfrom
Open
complete: add SetExitFunc() to override os.Exit in tests#147charlievieth wants to merge 1 commit intoposener:masterfrom
charlievieth wants to merge 1 commit intoposener:masterfrom
Conversation
Owner
|
I think that this breaks the current package API. No? |
This eliminates the need to use the unsupported bou.ke/monkey package, which fails to build on darwin/arm64.
charlievieth
force-pushed
the
cev/remove-monkey-patch
branch
from
e127f63 to
53d82ec
Compare
Author
|
@posener This change does not break the API or any existing code since all it does is add an additional function to the API for controlling how the complete library causes the program to exit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eliminates the need to use the unsupported bou.ke/monkey package,
which fails to build on darwin/arm64. A better solution might be to remove
the use of
os.Exitentirely since it's only called withos.Exit(0)and exitingthe program should be the responsibility of the caller to
Complete.