Allow user to set the "hasPrefix" function in Complete()#99
Closed
WillAbides wants to merge 2 commits intoposener:masterfrom
Closed
Allow user to set the "hasPrefix" function in Complete()#99WillAbides wants to merge 2 commits intoposener:masterfrom
WillAbides wants to merge 2 commits intoposener:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 89.76% 89.84% +0.08%
==========================================
Files 12 12
Lines 879 886 +7
==========================================
+ Hits 789 796 +7
Misses 79 79
Partials 11 11
Continue to review full report at Codecov.
|
Author
|
closing this in favor of #100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR comes from my desire to have case- and diacritic-insensitive completions. I have a command that takes usernames as arguments. When I type "wi" for the username argument I want to see "WillAbides" listed along with the usernames that start with lowercase "wi". The code currently in master doesn't allow for this because it always applies
strings.HasPrefix(option, a.Last).The simplest place I found to add this without affecting the other usage was as a variadic argument to
Complete(). The down side to making it an argument toComplete()is that means all arguments will use the same hasPrefix func.In case it helps to understand the use case, this is a simplified version of how I implemented case-insensitive completions: