Skip to content

Aggregation and Reference Column Hardening#372

Merged
rich-iannone merged 12 commits intoposit-dev:mainfrom
tylerriccio33:reference-maint
Mar 25, 2026
Merged

Aggregation and Reference Column Hardening#372
rich-iannone merged 12 commits intoposit-dev:mainfrom
tylerriccio33:reference-maint

Conversation

@tylerriccio33
Copy link
Copy Markdown
Contributor

Summary

The purpose of this PR is to further maintain and harden how aggregations, and the reference column in particular work. There are a few spots I'd like to target in this PR

  1. Briefs - the briefs were never implemented
  2. The validate stub generator was a little hacky. I made it slightly more informative and robust, and included it in CI (major change)!
  3. The type alias on unresolved columns for Reference was too narrow, so I expanded it to take collections.

Checklist

@tylerriccio33
Copy link
Copy Markdown
Contributor Author

Still tuning the ci and pre-commit ordering

@tylerriccio33
Copy link
Copy Markdown
Contributor Author

Alright, finally this is good to go. Found out ruff implements some line formatting very slightly differently across versions. I pinned ruff and made a note of this, to keep it in sync with the rev in pre-commit. CI will catch if they are out of sync.

@tylerriccio33 tylerriccio33 marked this pull request as ready for review March 25, 2026 01:15
Copy link
Copy Markdown
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the work you put into it!

@rich-iannone rich-iannone merged commit 85de513 into posit-dev:main Mar 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants