Move outputFile to lib/ and simplify - #530
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extracts the outputFile helper from index.js into a dedicated lib/outputFile.js module, reducing CLI entrypoint complexity and making the write-if-changed behavior reusable.
Changes:
- Added
lib/outputFile.jscontaining the extractedoutputFilehelper. - Updated
index.jsto import and use the new helper, removing the previous nested implementation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/outputFile.js | Introduces a shared outputFile helper for “write only if content changed” behavior. |
| index.js | Replaces the inline outputFile helper with an import from lib/outputFile.js. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -0,0 +1,11 @@ | |||
| import fs from 'node:fs/promises' | |||
| import path from 'node:path' | |||
Collaborator
Author
There was a problem hiding this comment.
Out of scope for this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
accessbeforereadFileis an anti-pattern; just handle the read error.