Repository navigation
fix(src/plugins): return default-exported plugins after validation - #281
Open
feritcemkahraman wants to merge 2 commits into
Open
feritcemkahraman wants to merge 2 commits into
feritcemkahraman wants to merge 2 commits into
Conversation
Member
|
Does it real issue or just issuer found by LLM? LLM found issues are not welcome here, please stop wasting my time. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable Changes
The loader unwraps a plugin's
defaultexport while validating it, but returns the original module wrapper inconfig.plugins. Passing that supposedly valid array into PostCSS then throws[object Object] is not a PostCSS plugin.Return the unwrapped export. Keep plugin creators themselves unchanged so existing invocation and plugin-type behavior is preserved. The existing interop fixture now runs through PostCSS, and a second regression verifies that a default-exported transform actually changes a declaration. Contributor entries follow CONTRIBUTING.md.
Commit Message Summary (CHANGELOG)
fix(src/plugins): return default-exported plugins after validation
Type
SemVer
Validation
Both processor regressions reproduce the original failure and pass with the fix. Changed JavaScript files pass ESLint.
Full unit suite on Node 22/Windows: 32 pass, 15 fail. The same 15 failures reproduce with the original source/tests (31 pass, 15 fail): imported CSS/SSS whitespace snapshots plus a path-separator assertion. Full ESLint also has existing import-order errors in unchanged files (25 after the change). These are recorded rather than marking the full-suite checklist complete.
Checklist